Allowing no scopes to be provided - #3943
Merged
Merged
Conversation
wmathurin
commented
Oct 13, 2025
wmathurin
commented
Contributor
- Not sending scope parameter in authorization url if no scopes defined
- Added test for scope parameter building method in SalesforceOAuthUnitTests.m
- Removed check for scopes in SFSDKAppConfig (class responsible for parsing bootconfig)
- Added new test suite BootconfigTests.swift
- Added check for id scope in SFIdentityCoordinator.m
- Added new helper class ScopeParser.swift
- Added new test suite ScopeParserTests.swift
- Moved some tests files that were in SalesforceSDKCore instead of SalesforceSDKCoreTests
- Not sending scope parameter in authorization url if no scopes defined - Added test for scope parameter building method in SalesforceOAuthUnitTests.m - Removed check for scopes in SFSDKAppConfig (class responsible for parsing bootconfig) - Added new test suite BootconfigTests.swift - Added check for id scope in SFIdentityCoordinator.m - Added new helper class ScopeParser.swift - Added new test suite ScopeParserTests.swift - Moved some tests files that were in SalesforceSDKCore instead of SalesforceSDKCoreTests
Clang Static Analysis Issues
Generated by 🚫 Danger |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (63.63%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #3943 +/- ##
==========================================
- Coverage 63.48% 63.01% -0.48%
==========================================
Files 250 249 -1
Lines 22506 22455 -51
==========================================
- Hits 14288 14150 -138
- Misses 8218 8305 +87
🚀 New features to boost your workflow:
|
bbirman
approved these changes
Oct 14, 2025
| return NO; | ||
| } | ||
| if (self.oauthScopes.count == 0) { | ||
| [[self class] createError:error withCode:SFSDKAppConfigErrorCodeNoOAuthScopes message:[SFSDKResourceUtils localizedString:@"appConfigValidationErrorNoOAuthScopes"]]; |
Member
There was a problem hiding this comment.
Could appConfigValidationErrorNoOAuthScopes be removed from the strings file?
- Removed oauthScopes (it's now optional) from sample apps bootconfig
Contributor
Author
|
Failing test does not fail locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.